Skip to content

Disable Upgrade All Boxes when there are no boxes #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kacperpaczos wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable Upgrade All Boxes when there are no boxes #217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb31add
feat: disable Upgrade All Boxes when there is nothing to upgrade
kacperpaczos Aug 22, 2026
69c8aba
simplify: drive Upgrade All through a window action
kacperpaczos Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ fn make_window(app: &Application) -> ApplicationWindow {
let has_distrobox = has_distrobox_installed();
let has_container_engine = has_podman_or_docker_installed();

// Actions first: the titlebar binds a button to one of them, and loading
// the boxes enables it.
set_window_actions(&window);
make_titlebar(&window, has_distrobox && has_container_engine);

let scrolled_win = gtk::ScrolledWindow::new();
Expand Down Expand Up @@ -119,8 +122,6 @@ fn make_window(app: &Application) -> ApplicationWindow {
render_not_installed(&scroll_area);
}

set_window_actions(&window);

window.present();

window
Expand Down Expand Up @@ -193,7 +194,10 @@ fn make_titlebar(window: &ApplicationWindow, dependencies_met: bool) {
let upgrade_btn = gtk::Button::from_icon_name(&get_available_icon_name(UPGRADE_ICON_NAMES));
// TRANSLATORS: Button tooltip
upgrade_btn.set_tooltip_text(Some(&gettext("Upgrade All Boxes")));
upgrade_btn.connect_clicked(move |_btn| upgrade_all_boxes());
// Bound to the window action rather than a click handler, so its
// sensitivity simply follows the action: load_boxes enables it only once
// there is at least one box to upgrade.
upgrade_btn.set_action_name(Some("win.upgrade-all"));

let assemble_img = make_assemble_image();
let assemble_btn = gtk::Button::new();
Expand Down Expand Up @@ -242,7 +246,6 @@ fn make_titlebar(window: &ApplicationWindow, dependencies_met: bool) {
// preference and About, none of which touch distrobox.
add_btn.set_sensitive(dependencies_met);
assemble_btn.set_sensitive(dependencies_met);
upgrade_btn.set_sensitive(dependencies_met);

let titlebar = adw::HeaderBar::new();

Expand All @@ -254,6 +257,19 @@ fn make_titlebar(window: &ApplicationWindow, dependencies_met: bool) {
window.set_titlebar(Some(&titlebar));
}

/// "Upgrade All Boxes" is a window action so the header button's sensitivity
/// follows it. Upgrading zero boxes is a no-op, so it is only enabled once
/// load_boxes has found something to upgrade - which also means it stays off
/// while distrobox or the container engine are missing.
fn set_upgrade_all_enabled(window: &ApplicationWindow, enabled: bool) {
if let Some(action) = window
.lookup_action("upgrade-all")
.and_downcast::<gio::SimpleAction>()
{
action.set_enabled(enabled);
}
}

fn set_window_actions(window: &ApplicationWindow) {
let action_close = gio::ActionEntry::builder("close")
.activate(|window: &ApplicationWindow, _, _| {
Expand All @@ -279,12 +295,19 @@ fn set_window_actions(window: &ApplicationWindow) {
})
.build();

let action_upgrade_all = gio::ActionEntry::builder("upgrade-all")
.activate(|_window: &ApplicationWindow, _, _| upgrade_all_boxes())
.build();

window.add_action_entries([
action_refresh,
action_about,
action_close,
action_set_preferred_terminal,
action_upgrade_all,
]);

set_upgrade_all_enabled(window, false);
}

fn get_main_menu_model() -> gio::MenuModel {
Expand Down Expand Up @@ -391,6 +414,8 @@ fn load_boxes(scroll_area: &gtk::Box, window: &ApplicationWindow, active_page: O

let boxes = get_all_distroboxes();

set_upgrade_all_enabled(window, !boxes.is_empty());

if boxes.is_empty() {
render_no_boxes_message(scroll_area);
return;
Expand Down