Hi! I've been sending a few contributions lately and kept noticing how much of the UI is already built nicely on libadwaita — ActionRow, EntryRow, PreferencesGroup, Toast, the HeaderBars. It feels right at home on GNOME.
While working I noticed a couple of spots still on older or lower-level pieces, and I wanted to ask how you feel about modernizing them before I put any work in:
adw::MessageDialog is used for most of the confirm/info popups. I believe it's been deprecated in more recent libadwaita in favour of adw::AlertDialog (which is also adaptive), and similarly adw::AboutWindow → adw::AboutDialog.- A few popups (create box, assemble, the applications list, rename, install binary, terminal prefs) are raw
gtk::Windows. Those could become adw::Window or the newer adw::Dialog, getting the adaptive/bottom-sheet behaviour and consistent styling for free.
Both would mean bumping the libadwaita feature flag from v1_4 to a newer one (and the matching minimum version), so it's really your call — some users may be on older distros. Would you be open to a gradual migration as small PRs, or would you rather keep the current minimum? Just wanted to ask before running ahead. Thanks!
Hi! I've been sending a few contributions lately and kept noticing how much of the UI is already built nicely on libadwaita — ActionRow, EntryRow, PreferencesGroup, Toast, the HeaderBars. It feels right at home on GNOME.
While working I noticed a couple of spots still on older or lower-level pieces, and I wanted to ask how you feel about modernizing them before I put any work in:
adw::MessageDialogis used for most of the confirm/info popups. I believe it's been deprecated in more recent libadwaita in favour ofadw::AlertDialog(which is also adaptive), and similarlyadw::AboutWindow→adw::AboutDialog.gtk::Windows. Those could becomeadw::Windowor the neweradw::Dialog, getting the adaptive/bottom-sheet behaviour and consistent styling for free.Both would mean bumping the libadwaita feature flag from
v1_4to a newer one (and the matching minimum version), so it's really your call — some users may be on older distros. Would you be open to a gradual migration as small PRs, or would you rather keep the current minimum? Just wanted to ask before running ahead. Thanks!