Open
Conversation
The `||` operator should not be used when setting default numerical values when the value could be a `0` The default values should only be used if the data is undefined, otherwise trust the data sent by the server. This is still not optimal solution, since we still have to maintain default values in multiple files.
Contributor
Author
|
Fix for #69 |
Contributor
|
allready fixed but not in a PR |
Contributor
Author
|
I see it's fixed for one specific setting, but other non-boolean settings might have the same issue. |
Contributor
|
some values are defaulted by the types and settings |
Contributor
|
fixed like |
Contributor
Author
|
My OCD still cringes seeing default values scattered and behind conditions... |
Contributor
sure, but its only a fix not a refactoring. so your version is much better, but on esp we have not unlimited space for lists and ohter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
||operator should not be used when setting default values when the value could be a0or an empty string. The default values should only be used if the data is undefined, otherwise trust the data sent by the server.This is still not optimal solution, since we still have to maintain default values in multiple files.