Switch to use romanisim#100
Open
yuedong0607 wants to merge 11 commits into
Open
Conversation
93c4cf2 to
ac91f55
Compare
Collaborator
Author
|
romanisim.models has not yet been included in the current release (v0.13.1) of romanisim. The merge needs to wait until the next release version. |
Collaborator
Author
|
I updated the romanisim dependency in pyproject.toml to point to the main branch, and all unit tests are now passing. I think the code is ready for review now. @arunkannawadi |
88819ea to
414da08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RP migrates the codebase to a new set of APIs in romanisim (here's an introduction of the new API), replacing all usages of galsim.roman. This change enables access to both CRDS and the roman-technical-information repository.
Current status:
noise.pyTODO / Open Questions (for this PR):
TODO / Open Questions (out of scope for this PR):