feat(gateway): support multi-port serving in deploy scripts #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update deploy-to-vmm.sh, docker-compose.yaml, and entrypoint.sh to support configurable number of serving ports via GATEWAY_SERVING_NUM_PORTS. - Replace GATEWAY_SERVING_ADDR with GATEWAY_SERVING_PORT + GATEWAY_SERVING_NUM_PORTS - Generate port range mappings in passt mode (host ports → container ports) - Pass SERVING_NUM_PORTS to container for entrypoint config generation - entrypoint.sh generates listen_port range when SERVING_NUM_PORTS > 1 - Default SERVING_NUM_PORTS=1 preserves backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GATEWAY_SERVING_ADDRwithGATEWAY_SERVING_PORT+GATEWAY_SERVING_NUM_PORTSin deploy scriptlisten_port = "443-462"style config whenSERVING_NUM_PORTS > 1SERVING_NUM_PORTS=1preserves full backwards compatibilityContext
Follow-up to #489 (multi-port TCP listening). The gateway binary now supports port ranges, but the deploy scripts still mapped a single serving port. This PR makes the deploy tooling aware of multi-port configuration.
Configuration
In
.env:Test Results
SERVING_NUM_PORTS=3generateslisten_port = "443-445"in container configlisten_port = 443(backwards compatible)cr.kvin.wang/dstack-gateway:multi-portimage