feat(vmm): add bridge networking support #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
force-pushed
the
feat/vmm-bridge
branch
from
5e1f4db to
5212498
Compare
Use separate --tcp-ports/--udp-ports arguments per port spec instead of comma-joining them, which could exceed passt's argument parser limit with large port ranges.
Add 'info' subcommand showing detailed VM information including instance ID, app URL, boot progress, and recent events. Also show instance_id column in verbose lsvm output.
Introduce dstack-port-forward crate with TCP (splice zero-copy with fallback) and UDP forwarding. Integrate ForwardService into VMM to dynamically manage port forwarding rules when bridge-mode guests report their eth0 IP via the network.eth0 vsock event. Key changes: - New port-forward crate with ForwardService for dynamic rule add/remove - Guest reports eth0 IP in dstack-prepare.sh via dstack-util notify-host - VMM persists guest IP to disk and hot-reloads forwarding rules - On VMM restart, forwarding is restored from persisted guest IPs - guest-agent now includes eth0 interfaces in network info API
Replace guest-side IP reporting with a DHCP server-side ReportDhcpLease PRPC endpoint. The VMM resolves MAC→VM via deterministic MAC derivation and reconfigures port forwarding on lease events. Refactor Networking from a tagged enum to a flat struct with a NetworkingMode enum, so shared fields (bridge name, mac_prefix) are accessible regardless of mode. Add mac_prefix config (0-3 hex bytes) for deterministic MAC generation, now applied to all networking modes.
…firewall rules Add dhcp-notify.sh script integration, nftables firewall rules for standalone bridges, and setup-bridge.sh improvements.
When `update_vm` is called with `update_ports=true`, also call `reconfigure_port_forward` so running bridge-mode VMs get their forwarding rules updated without requiring a restart.
kvinwang
force-pushed
the
feat/vmm-bridge
branch
from
c9be23f to
9b8e9cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
infocommand andinstance_idto vmm-cliforward_service_enabledconfig flag (default false, must be explicit in vmm.toml)Changes
vmm/: Bridge networking config, QEMU TAP/macvtap support, port forwarding integrationport-forward/: New crate for userspace TCP/UDP port forwardingscripts/setup-bridge.sh: Host bridge setup automationdocs/bridge-networking.md: Bridge networking guide with DHCP notification and firewall rulesvmm/src/vmm-cli.py: Addinfocommand with instance_id displayTest results
dstack-br0(IP 10.20.0.79, MAC 52:54:00:57:99:2f)-netdev bridge,br=dstack-br0for bridge-mode VMsforward_service_enabled = falsecorrectly disables port forwarding