chore: implement final branch protection and workflow tweaks by DrunkOnJava · Pull Request #251 · DrunkOnJava/ModularHomeInventory

DrunkOnJava · 2025-07-31T23:29:13Z

🔧 Final Hybrid Workflow Configuration

This PR completes the hybrid workflow setup by implementing the remaining configuration tweaks:

Changes

Added commit-limits.yml workflow
- Enforces ≤30 files or ≤800 lines per commit
- Validates branch naming conventions (feat/, fix/, docs/, etc.)
- Checks conventional commit message format
Updated PR management workflow
- Changed stale PR timing: 10 days (was 7)
- Changed auto-close timing: 30 days (was 14)
- Disabled auto-merge for small PRs (commented out)
Updated CODEOWNERS
- Changed all references from @griffinradcliffe to @DrunkOnJava
- Ensures GitHub recognizes your reviews for self-approval
Prepared branch protection update
- Created JSON config to require 1 review
- Enables strict status checks
- Enforces linear history (squash-only)

Next Steps

After merging this PR:

Apply the new branch protection rules using:

gh api repos/DrunkOnJava/ModularHomeInventory/branches/main/protection \
  --method PUT --input /tmp/protect-main.json

Monitor tonight's first dev→main rebase (3 AM UTC)

Testing

CI will validate this PR follows the new rules
Commit limits workflow will run on this PR

Fixes the final configuration gaps identified in the hybrid workflow analysis.

@DrunkOnJava

- Add commit-limits.yml workflow to enforce size/naming rules - Update PR management: stale after 10d, close after 30d - Disable auto-merge for small PRs (commented out) - Update CODEOWNERS to use @DrunkOnJava - Prepare branch protection JSON for 1-review requirement

github-actions · 2025-07-31T23:29:21Z

👋 Welcome to the Hybrid Workflow!

⚠️ Important: This PR targets main directly. Please ensure:

This is a critical fix or thoroughly tested feature
All tests pass
You've considered creating this PR to dev first

PR Guidelines

Keep PRs focused on a single feature or fix
Ensure all tests pass before review
Update documentation if needed
Respond to review feedback promptly

Review Process

PRs to main require:

Approved review from maintainer
All status checks passing
No merge conflicts

github-actions · 2025-07-31T23:29:39Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

Copilot

Pull Request Overview

This PR implements the final configuration changes for a hybrid workflow setup, focusing on commit limits, PR management adjustments, and ownership updates. The changes establish stricter code quality controls while adjusting automated PR handling timelines.

Key changes include:

Added a comprehensive commit validation workflow with size limits and naming conventions
Extended PR stale/close timings and disabled auto-merge functionality
Updated all code ownership references to reflect current maintainer

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
.github/workflows/commit-limits.yml	New workflow enforcing commit size limits, branch naming, and conventional commit format
.github/workflows/pr-management.yml	Disabled auto-merge functionality and extended PR lifecycle timings
.github/CODEOWNERS	Updated all ownership references from @griffinradcliffe to @DrunkOnJava

Copilot · 2025-07-31T23:29:47Z

.github/workflows/commit-limits.yml

+            lines_added=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$1} END {print sum}')
+            lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum}')


The awk command will output an empty string when there are no lines to sum, which could cause issues in arithmetic operations. Consider adding a default value: awk '{sum+=$1} END {print sum+0}' to ensure it always outputs a number.

Suggested change

lines_added=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$1} END {print sum}')

lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum}')

lines_added=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$1} END {print sum+0}')

lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum+0}')

Copilot · 2025-07-31T23:29:47Z

.github/workflows/commit-limits.yml

+            # Get commit stats
+            files_changed=$(git diff-tree --no-commit-id --name-only -r $commit | wc -l)
+            lines_added=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$1} END {print sum}')
+            lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum}')


The awk command will output an empty string when there are no lines to sum, which could cause issues in arithmetic operations. Consider adding a default value: awk '{sum+=$2} END {print sum+0}' to ensure it always outputs a number.

Suggested change

lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum}')

lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum+0}')

Copilot · 2025-07-31T23:29:47Z

.github/workflows/commit-limits.yml

+            files_changed=$(git diff-tree --no-commit-id --name-only -r $commit | wc -l)
+            lines_added=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$1} END {print sum}')
+            lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit | awk '{sum+=$2} END {print sum}')
+            total_lines=$((lines_added + lines_deleted))


This arithmetic operation could fail if lines_added or lines_deleted are empty strings (when commits have no changes). The variables should be validated or defaulted to 0 before this calculation.

Suggested change

total_lines=$((lines_added + lines_deleted))

total_lines=$(( ${lines_added:-0} + ${lines_deleted:-0} ))

- Add comprehensive hybrid workflow section - Update quick start with git hooks setup - Include Claude wrapper usage instructions - Document branch protection and CI/CD status - Add workflow rules table for clarity

github-actions · 2025-07-31T23:47:36Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

- Automatically updates architecture dashboard on push to main/develop - Triggers on build workflow completion to capture errors - Analyzes build errors, code quality, and git history - Deploys updated dashboard to Vercel - Posts deployment status on pull requests This workflow ensures the architecture dashboard stays up-to-date with the latest codebase analysis and build health metrics.

github-actions · 2025-08-01T03:19:33Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

- Updated Claude settings and GitHub sync status - Enhanced gitignore patterns - Updated project.yml and Config/project.yml - Refined Makefile build configurations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Updated Infrastructure-Monitoring package configuration - Moved to properly named InfrastructureMonitoring source directory - Cleaned up deprecated monitoring source files - Prepared for new monitoring architecture 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Updated Infrastructure-Network package configuration - Moved to properly named InfrastructureNetwork source directory - Cleaned up deprecated network source files - Maintained networking interfaces and protocols 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Updated Infrastructure-Security package configuration - Moved to properly named InfrastructureSecurity source directory - Cleaned up deprecated security source files - Maintained security interfaces and authentication protocols 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Reorganized Infrastructure-Storage with proper source structure - Updated Services-Business and Services-External modules - Enhanced Foundation layer with proper configurations - Updated UI components and feature views - Cleaned up Xcode project files and schemes - Added new foundation models and core functionality - Updated supporting files and test configurations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-08-01T06:29:10Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

github-actions · 2025-08-01T06:29:54Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

github-actions · 2025-08-01T06:30:13Z

🧪 Test Results

iPhone Tests: ✅ Passed
iPad Tests: ✅ Passed
Coverage: See artifacts for detailed report

Test Summary:

Unit Tests: Skipped (not available)
UI Tests: Skipped (not available)
Accessibility Tests: Executed

View detailed results and coverage reports in the Actions tab.

github-actions · 2025-08-01T06:30:29Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

github-actions · 2025-08-01T06:31:08Z

🧪 Test Results

iPhone Tests: ✅ Passed
iPad Tests: ✅ Passed
Coverage: See artifacts for detailed report

Test Summary:

Unit Tests: Skipped (not available)
UI Tests: Skipped (not available)
Accessibility Tests: Executed

View detailed results and coverage reports in the Actions tab.

github-actions · 2025-08-01T06:31:50Z

🧪 Test Results

iPhone Tests: ✅ Passed
iPad Tests: ✅ Passed
Coverage: See artifacts for detailed report

Test Summary:

Unit Tests: Skipped (not available)
UI Tests: Skipped (not available)
Accessibility Tests: Executed

View detailed results and coverage reports in the Actions tab.

github-actions · 2025-08-01T06:32:24Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

github-actions · 2025-08-01T06:32:59Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

github-actions · 2025-08-01T06:33:41Z

🧪 Test Results

iPhone Tests: ✅ Passed
iPad Tests: ✅ Passed
Coverage: See artifacts for detailed report

Test Summary:

Unit Tests: Skipped (not available)
UI Tests: Skipped (not available)
Accessibility Tests: Executed

View detailed results and coverage reports in the Actions tab.

github-actions · 2025-08-01T06:34:22Z

🔍 PR Validation Results

Build Status: ✅ Passed
SwiftLint: ⚠️ Issues found
Project Structure: ❌ Issues found
Compilation: ❌ Failed

This comment was automatically generated by the PR validation workflow.

github-actions · 2025-08-01T06:35:07Z

🧪 Test Results

iPhone Tests: ✅ Passed
iPad Tests: ✅ Passed
Coverage: See artifacts for detailed report

Test Summary:

Unit Tests: Skipped (not available)
UI Tests: Skipped (not available)
Accessibility Tests: Executed

View detailed results and coverage reports in the Actions tab.

github-actions · 2025-08-01T06:36:09Z

🧪 Test Results

iPhone Tests: ✅ Passed
iPad Tests: ✅ Passed
Coverage: See artifacts for detailed report

Test Summary:

Unit Tests: Skipped (not available)
UI Tests: Skipped (not available)
Accessibility Tests: Executed

View detailed results and coverage reports in the Actions tab.

Copilot AI review requested due to automatic review settings July 31, 2025 23:29

github-actions bot added size/L needs-careful-review target/main labels Jul 31, 2025

Copilot AI reviewed Jul 31, 2025

View reviewed changes

docs: update README with hybrid workflow documentation

2f420eb

- Add comprehensive hybrid workflow section - Update quick start with git hooks setup - Include Claude wrapper usage instructions - Document branch protection and CI/CD status - Add workflow rules table for clarity

github-actions bot added size/L and removed size/L labels Jul 31, 2025

github-actions bot added size/XL and removed size/L labels Aug 1, 2025

github-actions bot added size/XL and removed size/XL labels Aug 1, 2025

DrunkOnJava and others added 2 commits August 1, 2025 02:28

github-actions bot added size/XL and removed size/XL labels Aug 1, 2025

github-actions bot added the size/XL label Aug 1, 2025

sync: final sync status update

d53f21c

github-actions bot added size/XL and removed size/XL labels Aug 1, 2025

DrunkOnJava merged commit d53f21c into main Aug 1, 2025
7 of 8 checks passed

DrunkOnJava deleted the chore/restore-protection branch August 1, 2025 06:29

		lines_added=$(git diff-tree --no-commit-id --numstat -r $commit \| awk '{sum+=$1} END {print sum}')
		lines_deleted=$(git diff-tree --no-commit-id --numstat -r $commit \| awk '{sum+=$2} END {print sum}')

	total_lines=$((lines_added + lines_deleted))
	total_lines=$(( ${lines_added:-0} + ${lines_deleted:-0} ))

Conversation

DrunkOnJava commented Jul 31, 2025

🔧 Final Hybrid Workflow Configuration

Changes

Next Steps

Testing

Uh oh!

github-actions bot commented Jul 31, 2025

👋 Welcome to the Hybrid Workflow!

PR Guidelines

Review Process

Uh oh!

github-actions bot commented Jul 31, 2025

🔍 PR Validation Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 31, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🧪 Test Results

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🧪 Test Results

Uh oh!

github-actions bot commented Aug 1, 2025

🧪 Test Results

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🧪 Test Results

Uh oh!

github-actions bot commented Aug 1, 2025

🔍 PR Validation Results

Uh oh!

github-actions bot commented Aug 1, 2025

🧪 Test Results

Uh oh!

github-actions bot commented Aug 1, 2025

🧪 Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants