Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing device-table entry for the Adreno 831:
attached to the Adreno 830 entry (
GPUId(chip_id=0x44050001, name="Adreno (TM) 830")), guarded so it becomes a no-op once Mesa upstream carries the part.Why
Mesa upstream
freedreno_devices.pydoes not currently index the Adreno 831 chip ID (0x44050100), causing Turnip to reject device creation withVK_ERROR_INCOMPATIBLE_DRIVER:Adding this entry allows Turnip to initialize on Adreno 831 devices such as the XREAL AURA.
Tested on
0x44050100, Android XR)Scope
0x44050100.if '0x44050100' not in Path(DEVICES).read_text():so it is safely skipped once Mesa main carries the entry upstream.