Skip to content

Fix tsub-ok.c #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gorisanson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix tsub-ok.c #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions site/content/chapter2/code/tsub-ok.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,16 @@
#include <limits.h>

/* Determine whether arguments can be substracted without overflow */
int tsub_ok(int x, int y)
{
int res = 1;

(y == INT_MIN) && (res = 0);
// if (y == INT_MIN) res = 0;

int tsub_ok(int x, int y) {
int sub = x - y;
int pos_over = x > 0 && y < 0 && sub < 0;
int pos_over = x >= 0 && y < 0 && sub < 0;
int neg_over = x < 0 && y > 0 && sub > 0;

res = res && !(pos_over || neg_over);

return res;
return !(pos_over || neg_over);
}

int main(int argc, char* argv[]) {
assert(!tsub_ok(0x00, INT_MIN));
assert(tsub_ok(0x00, 0x00));
return 0;
int main(int argc, char *argv[]) {
assert(!tsub_ok(0x00, INT_MIN));
assert(tsub_ok(-1, INT_MIN));
assert(tsub_ok(0x00, 0x00));
return 0;
}