Skip to content

[Exchanges] fix get_extended_additional_connector_config in ws call #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeDSM merged 1 commit into from
Mar 20, 2026
Merged

[Exchanges] fix get_extended_additional_connector_config in ws call #3318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/trading/octobot_trading/exchanges/connectors/ccxt/ccxt_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,9 @@ def add_options(self, options_dict):

@classmethod
def get_extended_additional_connector_config(cls, additional_config: dict):
"""
implement in subclass if necessary
"""
extended_ccxt_options = {}
if extended_ccxt_options:
if additional_config and ccxt_constants.CCXT_OPTIONS in additional_config:
Expand Down
8 changes: 4 additions & 4 deletions packages/trading/octobot_trading/exchanges/connectors/ccxt/ccxt_websocket_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ def __init__(
additional_config
)
if self.USE_REST_CONNECTOR_ADDITIONAL_CONFIG:
self.additional_config = {
**(self.additional_config or {}),
**self.exchange_manager.exchange.get_extended_additional_connector_config()
}
self.additional_config = (
self.exchange_manager.exchange.connector.get_extended_additional_connector_config(self.additional_config)
if self.exchange_manager.exchange.connector else self.additional_config
)
self.headers: dict[str, str] = {}
self.options: dict[str, typing.Any] = {
"newUpdates": True, # only get new updates from trades and ohlcv (don't return the full cached history)
Expand Down
Loading