fix(styles): keep resized textareas inside their column - #513
Merged
Merged
Conversation
Textareas had no max-width or resize constraint, so dragging the native resize handle could grow a textarea wider than its column (or edit panel), visibly overlapping sibling UI on the stage. Refs #217
Collaborator
Author
|
🎉 This PR is included in version 5.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A textarea could be dragged by its native resize handle until it was wider than its column. On v5.9.2 the editor preview overflowed by the full drag distance, running under the controls sidebar.
The shared
.formeo textarearule now setsmax-width: 100%; resize: vertical;. It applies to rendered forms too, where columns have the same missing containment.Refs #217
Testing
tests/textarea-resize.spec.js: before the fix the textarea's right edge ended 600px past its column; it now stays inside.npm testandnpm run lintpass. Playwright: full suite passes.