feat: add reorderOption, attributeNameRequired, selectConfigKey and duplicateFieldName - #87
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments remain, and the supplied assessments find the changes ready for approval.
Review effort: Lite
Findings: None
What changed in this PR
Adds four editor translations across supported locales and normalizes placeholder spacing.
Changes:
- Adds
attributeNameRequired,duplicateFieldName,reorderOption, andselectConfigKey. - Corrects selected translations and placeholder formatting.
- Updates generated locale JSON files.
| File | Summary |
|---|---|
src/lang/zh-HK.lang |
Locale translations |
src/lang/zh-HK.json |
Generated locale mirror |
src/lang/zh-CN.lang |
Locale translations |
src/lang/zh-CN.json |
Generated locale mirror |
src/lang/tr-TR.lang |
Locale translations |
src/lang/tr-TR.json |
Generated locale mirror |
src/lang/th-TH.lang |
Locale translations |
src/lang/ru-RU.lang |
Locale translations |
src/lang/ru-RU.json |
Generated locale mirror |
src/lang/ro-RO.lang |
Locale translations |
src/lang/ro-RO.json |
Generated locale mirror |
src/lang/pt-PT.lang |
Locale translations |
src/lang/pt-PT.json |
Generated locale mirror |
src/lang/pt-BR.lang |
Locale translations |
src/lang/pt-BR.json |
Generated locale mirror |
src/lang/pl-PL.lang |
Locale translations |
src/lang/pl-PL.json |
Generated locale mirror |
src/lang/nb-NO.lang |
Locale translations |
src/lang/nb-NO.json |
Generated locale mirror |
src/lang/ja-JP.lang |
Locale translations |
src/lang/ja-JP.json |
Generated locale mirror |
src/lang/it-IT.lang |
Locale translations |
src/lang/it-IT.json |
Generated locale mirror |
src/lang/hu-HU.lang |
Locale translations |
src/lang/hi-IN.lang |
Locale translations |
src/lang/he-IL.lang |
Locale translations |
src/lang/fr-FR.lang |
Locale translations |
src/lang/fr-FR.json |
Generated locale mirror |
src/lang/fi-FI.lang |
Locale translations |
src/lang/fi-FI.json |
Generated locale mirror |
src/lang/fa-IR.lang |
Locale translations |
src/lang/fa-IR.json |
Generated locale mirror |
src/lang/es-ES.lang |
Locale translations |
src/lang/es-ES.json |
Generated locale mirror |
src/lang/en-US.lang |
Locale translations |
src/lang/en-US.json |
Generated locale mirror |
src/lang/de-DE.lang |
Locale translations |
src/lang/de-DE.json |
Generated locale mirror |
src/lang/cs-CZ.lang |
Locale translations |
src/lang/ar-TN.lang |
Locale translations |
src/lang/ar-TN.json |
Generated locale mirror |
src/lang/af-ZA.lang |
Locale translations |
src/lang/af-ZA.json |
Generated locale mirror |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds four editor strings that Formeo already uses with English fallbacks, translated for every locale with
npm run translate:reorderOptionattributeNameRequiredselectConfigKeyduplicateFieldNameduplicateFieldNameis used by the new duplicate-name hint in Formeo (Draggable/formeo, branchfix/editor-attr-guards).Also:
{placeholders}, e.g." {attribute} ", in the new keys and inattributeNotPermitted,controls.filteringTerm,pages.removeandpages.removeConfirm. fr-FR guillemets keep their spaces.Follow-up worth considering:
tools/placeholders.jsrestorePlaceholdersonly trims inside thetranslate="no"span, so future runs can reintroduce quote-adjacent spaces.Testing
npm test: 38/38.npm run lintcan't run here, becausebiomeisn't installed as a devDependency. That problem predates this branch.