Repository navigation
Fix the three tests that fail on main - #5
Merged
Merged
Conversation
Version tests now compare against the VERSION file so a bump does not leave them stale. A non-object mcpToolCall or getMcpToolsToolCall fails the run as a malformed Cursor response. Co-authored-by: Dor Ingber <Doringber@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CI job on
mainwas already red before the readiness work. These are the three failures.tests/test_version.pycompared the resolver to the hardcoded string0.1.1afterVERSIONmoved to0.1.2. Both tests now readVERSIONand assert the resolver matches that file, so the next bump does not break them.test_cursor_agent_client_normalizes_malformed_tool_payloadsexpects a non-objectmcpToolCallto fail the run._tool_payloadtreated a list as an empty object and reported success.mcpToolCallandgetMcpToolsToolCallnow raiseValueErrorwhen the value is not an object, which the client reports asMalformed Cursor agent response.Tests