Repository navigation
Docs audit: fix stale verification tooling, test ContainerImage helpers, re-measure coverage - #56
Merged
Merged
Conversation
…sure coverage docs/TESTING.md and CLAUDE.md still described a 'check' SwiftPM command plugin (swift package --disable-sandbox check) that no longer exists — PR #20 replaced it with the Tools/coverage executable to avoid the plugin build-lock deadlock. Document the real flow: swift test + swift run coverage. The coverage table had drifted from measurement: - AppState ~93% -> ~86% (update-check paths landed after the table was written) - CLIContainerCreator ~84% -> ~95% - Models claimed 90-100% but ContainerImage measured 43%: its pure helpers (shortDigest, formattedSize, formatImageBytes) had no tests. Add ContainerImageTests (5 tests, pure logic tier per the doc's own two-tier rule) — ContainerImage is now 91%. Measured tier-1 blended coverage: ~90%. All figures from a fresh local llvm-cov run: 113 tests in 28 suites pass.
README audit found no drift — every claim checked out against the code (macOS 26 requirement, Swift 6.2 tools version, LSUIElement, 2s/15s adaptive polling defaults, start/stop/restart/delete/logs/shell actions, CONSAI_E2E gate, cask token, screenshots, CLAUDE.md R1/R11 links; Info.plist 0.1.0 matches CHANGELOG [0.1.0]). Package.swift comments still pointed at the removed scripts/bundle.sh (twice) — PR #20 replaced it with the native 'swift run bundle' tool. Record the audit fixes under [Unreleased] > Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
27686665489— the only failure in the repo's history — never started a single step. Its job annotation reads: "The job was not started because recent account payments have failed or your spending limit needs to be increased." It was a transient GitHub Actions billing failure on thetest/appstate-coveragebranch; that PR (Extract AppState into testable ConsaiKit + comprehensive unit tests #20) was later merged, and its second commit deliberately deleted.github/workflows/ci.yml(hosted runners can't build the container SDK graph — documented in CHANGELOG's Known limitations). Main's last CI run was green. There is no workflow left to turn green, so this PR is docs-only; verification is local, as the project intends.Changes
docs/TESTING.md/CLAUDE.mdR7 still described the removedcheckSwiftPM command plugin; document the real flow (swift test+swift run coverage).ContainerImagemeasured 43% — its pure helpers (shortDigest,formattedSize,formatImageBytes) had no tests, soContainerImageTestsadds 5 tests in the doc's own pure-logic tier (now 91%).LSUIElement, 2s/15s adaptive polling defaults, all row/detail actions,CONSAI_E2Egate, cask token, screenshots, R1/R11 links;Info.plist0.1.0 matches CHANGELOG [0.1.0]). Fixed the stalescripts/bundle.shreferences inPackage.swiftcomments and recorded everything under[Unreleased] > Fixed.Verification
swift build— clean (269 s cold, 64 s incremental, Command Line Tools / Swift 6.3.3)swift test --enable-code-coverage— 113 tests in 28 suites passswift run coverage— table figures re-measured from this runNo hosted CI exists for this repo by design (see CHANGELOG 'Known limitations'), so no checks will appear on this PR.