Repository navigation
fix(web): merge selected sidebar sections by project - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting Active and Working together repeated each project's heading and split its threads across separate sections. Selected sections now merge into one group per project, with Working threads below Active threads. The open thread also stays hidden when its section is filtered out.
Single-section views retain drag reordering; merged views disable reordering because section boundaries no longer represent their visual order. This affects the shared web/desktop sidebar; the native mobile sidebar is unchanged. Demo data, tab names, and beta-setting overrides are excluded. Ordinary idle sessions now show Working; Waiting is reserved for blocked thread waits or awaited background work, covered by a regression test.
Validation:
vp run check:changedpassed (108 tests, format, lint, knip, and affected-package typechecks). Browser verification used the demo's 3 Active and 4 Working threads: confirmed one heading per project, Working below Active, and an open Working thread hidden in Active. Existing purity warnings remain.Both clips use the Working label to isolate the comparison of section merging.
Before (dark mode, 10 seconds, 60 fps (motion-interpolated)):
before.mp4
After (dark mode, 10 seconds, 60 fps (motion-interpolated)):
after.mp4
Created with GPT-6.1-Sol in the Codex harness.