fix(databases): resolve crash when opening rebuild database dialog#4763
Merged
Conversation
dosubot
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Opening the Rebuild Database dialog crashed the page with
Error: Primitive.button failed to slot onto its children. Expected a single React element child or \Slottable`.` — a regression from the Tailwind v4 / shadcn update (#4706) shipped in v0.29.10.Changes
AlertDialogActionnow wraps its children in<Button asChild>internally, so passingasChildwith a nested<Button>made the Radix Slot receive an array of children and throw. Replaced it with a plainAlertDialogActionusingvariant="destructive"+disabled, matching the idiom used by the rest of the alert dialogs (e.g.dialog-action.tsx). The loading state is still visible on the trigger button while the rebuild runs.AlertDialogDescriptionrenders a<p>, but contained<p>and<ul>children (hydration warnings). It now usesasChildwith a<div>wrapper.Issues related
Closes #4760