feat(ci): pin install.sh release asset to the released version#4758
Merged
Conversation
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install.sh attached to each release previously installed whatever version was current at run time (
latest/ GitHub auto-detection). This pinsDOKPLOY_VERSIONto the release's own version before attaching, so running a release's install.sh installs exactly that version. Env override still works (DOKPLOY_VERSION=canary bash install.sh).All 163 existing release assets were re-uploaded with the same pinning applied (old scripts: image pinned to the release tag; modern scripts:
DOKPLOY_VERSIONdefault injected).