fix(ui): enable vertical scroll on collapsed sidebar#4755
Merged
Conversation
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This fixes a bug where the sidebar's vertical scroll was disabled while in the collapsed (icon) state. It also explicitly removes the horizontal scrolling bug that was present in
v0.29.8.How & Why
In the recent Tailwind v4 / Shadcn update, the
SidebarContentcomponent hadgroup-data-[collapsible=icon]:overflow-hiddenadded to it, which hid all overflow when collapsed.This PR swaps
overflow-auto group-data-[collapsible=icon]:overflow-hiddentooverflow-y-auto overflow-x-hidden, which restores vertical scrolling capabilities while preventing the sidebar from overflowing horizontally.Checklist
canarybranch.Issues related
closes #4754