fix(ai): use nullable instead of optional for configFiles in AI suggestion schema#4732
Merged
Merged
Conversation
…stion schema OpenAI strict mode for response_format requires every property to be listed in 'required'. Optional fields must instead be modeled as nullable so the key stays required while still allowing no value. Fixes #4267
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response_formatrequires every property in the JSON Schema to be listed inrequired. Optional Zod fields (.optional()) don't satisfy this, causing the AI Assistant template generator to fail at Step 2 with gpt-4o and other strict-mode models.configFilesfrom.optional()to.nullable()inpackages/server/src/services/ai.ts, which keeps the key inrequiredwhile allowingnull/no config files.Fixes #4267