feat: Use Todoist OAuth for CLI login#14
Draft
amix wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The CLI login flow now asks Todoist for a Comms-audience token instead of using the legacy Comms OAuth endpoints.
What was changed
resource=comms, Todoist-compatible comma-separated scopes, and the restricted PKCE verifier alphabet.comms:*scope families.Out of scope
@doist/cli-core.@doist/cli-core/@doist/comms-sdktypes.Testing
npm test -- src/lib/auth-provider.test.tspassed.npx oxlint src/lib/auth-provider.ts src/lib/auth-provider.test.ts src/commands/auth/auth.test.tspassed.npx oxfmt --check src/lib/auth-provider.ts src/lib/auth-provider.test.ts src/commands/auth/auth.test.ts README.mdpassed.doistbot review stagedran once; concrete Todoist protocol findings were applied.npm test -- src/commands/auth/auth.test.tsfails in this checkout because@doist/cli-core/testingdoes not exportcaptureConsole.npm run type-checkfails in this checkout from the same baseline mismatch plus SDK type drift (@doist/cli-coreaccount/testing exports,@doist/comms-sdkattachment/includeRemoved types, and existingactiveBundle/activeAccounttype errors).