fix: enforce CreatePostForm validation on post creation#257
Conversation
CreatePostForm was instantiated in create_post() but .validate() was never called, so all its validators (title length, required tags, abstract length, etc.) were silently bypassed. The handler read raw values straight from request.form and only checked that content and abstract were non-empty. This let a 1-character title or empty tags field through, while the form's own rules (Length(min=4, max=75) on title, InputRequired() on tags/category, Length(min=150, max=200) on abstract) were never enforced. Validate the form and use its cleaned field data when building the new Post; fall back to the existing 'empty' flash message on failure and log the specific validation errors.
|
Warning Review limit reached
More reviews will be available in 28 minutes and 45 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
CreatePostForm was instantiated in create_post() but .validate() was never called, so all its validators (title length, required tags, abstract length, etc.) were silently bypassed. The handler read raw values straight from request.form and only checked that content and abstract were non-empty.
This let a 1-character title or empty tags field through, while the form's own rules (Length(min=4, max=75) on title, InputRequired() on tags/category, Length(min=150, max=200) on abstract) were never enforced.
Validate the form and use its cleaned field data when building the new Post; fall back to the existing 'empty' flash message on failure and log the specific validation errors.