Explore pups pagination fix#239
Open
qlpqlp wants to merge 3 commits into
Open
Conversation
Fixed pagination issue were wen going to page 2 it jumped to page 1
PaginationController now supports: setFilter((item, query) => boolean) → set once setQuery(query) → update often internal applyFilter() to reuse the same predicate clearFilter() helper Backward compatibility is preserved: existing setFilter(fn) usage still works.
Contributor
Author
|
sorry I was using wrong branch |
This reverts commit c14b136.
elusiveshiba
requested changes
May 22, 2026
Contributor
There was a problem hiding this comment.
These changes may have an unintended side effects, hiding changes if pup descriptions/logos etc. change without the ID being modified.
Seems to me the issue source is actually in src/components/common/paginator/paginator-controller.js's setData method.
It shouldn't have this.currentPage = 1; running every time setData is called.
Instead, it could just keep the current page, unless the total page count has reduced in which case it could just set the last page.
For eg.
const totalPages = this.getTotalPages();
this.currentPage = Math.min(this.currentPage, Math.max(totalPages, 1));
Also, does a fix need to be applied to the pup library page too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.