fix: remove shell interpretation from asset decryption - #204
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧹 ESLintQuality check 1 of 3 ✅ Zero warnings. |
Contributor
🧪 VitestQuality check 2 of 3 ✅ Vitest completed successfully. |
Contributor
🎭 PlaywrightQuality check 3 of 3 ✅ Playwright completed successfully. |
Contributor
🗺️ XState v5 State Machine Diff VisualizationArchitecture visualization Base No XState state-machine topology changes detected. Download canonical graphs, structured diff, Mermaid, and diagnostics |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 65 +2
Lines 1453 1515 +62
Branches 309 320 +11
=========================================
+ Hits 1453 1515 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
Code reviewed and approved. QA pass. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
What changed
unzipexecution with in-process ZipCrypto extraction1Library decision
The two existing archives were inspected without decrypting or printing their contents. Both use traditional PKWARE ZipCrypto with stored/deflated entries and no WinZip AES records.
@zip.js/zip.jswas selected because it supports the exact formats in use, runs on Node.js, has zero third-party dependencies, supports strict ambiguity checks, and accepts the password in-process. This materially improves both security and Windows/Linux compatibility compared withexecFileSync, which would remove shell interpretation but still expose the password in child-process arguments.No existing pipeline documentation described the external
unzipimplementation, so no documentation change was required.Verification
GHOST_ASSET_KEY_DOCTORDEREK_COMexplicitly absentgit diff --checkpassedDeployment confirmation
The same-repository Vercel preview build can exercise the actual encrypted archives with the existing protected environment secret. No secret value is logged or exposed by this branch.