Skip to content

feat: addition of alliance.svg and djed-logo.svg and replacing the png files across the landing page#49

Merged
Zahnentferner merged 1 commit into
DjedAlliance:mainfrom
reach2saksham:feat/djed-svg-logo-add
May 20, 2026
Merged

feat: addition of alliance.svg and djed-logo.svg and replacing the png files across the landing page#49
Zahnentferner merged 1 commit into
DjedAlliance:mainfrom
reach2saksham:feat/djed-svg-logo-add

Conversation

@reach2saksham
Copy link
Copy Markdown
Contributor

@reach2saksham reach2saksham commented Mar 27, 2026

Addressed Issues:

Fixes #48

Screenshots/Recordings:

Additional Notes:

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.

AI Usage Disclosure

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

⚠️ AI Notice - Important!

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Summary by CodeRabbit

  • Chores
    • Replaced several raster logos and the site favicon with SVG assets for crisper visuals.
    • Updated the organization name shown in the site logo to the new branding.
  • Style
    • Refined footer logo sizing, spacing, and alignment for improved visual consistency across breakpoints.
    • Ensured header and homepage logo images match the updated branding and iconography.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 27, 2026

📝 Walkthrough

Walkthrough

Replaced PNG logos with SVGs across README, index.html, header, home, and footer; adjusted footer layout classes and set fixed footer logo size. No runtime logic, exports, or public API changes.

Changes

Logo & layout updates

Layer / File(s) Summary
Footer logo import and layout
src/components/pages/footer/Footer.tsx
Update footer logo import to djed-logo.svg; adjust top-row flex/spacing/alignment classes; add items-center to wrapper; remove mt-3 from label; set logo <img> to w-10 h-10.
Header logo import
src/components/pages/header/Header.tsx
Swap header Logo import from djed-logo.pngdjed-logo.svg; header image uses the new asset.
Home page Alliance image
src/components/pages/home/Home.tsx
Change Alliance image source from /gallery/Alliance.png/readme-assets/Alliance.svg (className and alt unchanged).
README logo image
README.md
Replace centered logo: alt NautilusDjed Alliance, asset public/readme-assets/Alliance.pngpublic/readme-assets/Alliance.svg (width unchanged).
Site favicon
index.html
Update favicon reference from /src/assets/djed-logo.png/src/assets/djed-logo.svg.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • Zahnentferner

Poem

🐰 I swapped the PNGs for crisp SVG light,

Vectors hop in, edges sharp and bright.
Footers aligned, the logo snug and small,
Djed Alliance gleams — a lighter site for all. 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding SVG assets and replacing PNG files across the landing page with SVGs.
Linked Issues check ✅ Passed The PR successfully implements all requirements from issue #48: SVG assets (alliance.svg and djed-logo.svg) are added and PNG files are replaced across the landing page.
Out of Scope Changes check ✅ Passed All changes are in-scope: README.md asset update, favicon change, and logo replacements in Header, Footer, and Home components are directly related to the SVG migration objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Line 7: Update the img tag's alt attribute to accurately describe the image:
replace alt="Nautilus" with something like alt="Djed Alliance logo" in the
README's <img> element so the alt text matches the Djed Alliance SVG and
improves accessibility and documentation accuracy.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 984e9e25-1260-4d7d-aa8f-a6745343823d

📥 Commits

Reviewing files that changed from the base of the PR and between 60eddcd and 6e87a9f.

⛔ Files ignored due to path filters (2)
  • public/readme-assets/alliance.svg is excluded by !**/*.svg
  • src/assets/djed-logo.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • README.md
  • index.html
  • src/components/pages/footer/Footer.tsx
  • src/components/pages/header/Header.tsx
  • src/components/pages/home/Home.tsx

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

@Zahnentferner Zahnentferner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts...

@reach2saksham reach2saksham force-pushed the feat/djed-svg-logo-add branch from 7acaaac to 8c9cfc4 Compare May 19, 2026 12:45
@Zahnentferner Zahnentferner merged commit be31961 into DjedAlliance:main May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creation of the Djed Logo's SVG file

2 participants