fix(landlord): validate maxRetries as a positive integer#6
Merged
Conversation
maxRetries was an unconstrained z.number(). Negative or zero values made a tenant escalate without ever running (the attempt < maxRetries loop never executes), and fractional values produced an extra attempt. Constrain it to int().min(1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
ContractSchema.maxRetrieswas an unconstrainedz.number(). The orchestrator uses it asfor (let attempt = 0; attempt < contract.maxRetries; attempt++), so:0or negative → the loop never runs, and the tenant escalates without ever attempting its work.2.5) → an unexpected extra attempt.This constrains the field to
z.number().int().min(1), guaranteeing at least one attempt and rejecting invalid plans at parse time. The default of3is unchanged.Verification
pnpm --filter landlord typecheck✓pnpm --filter landlord test✓ (40 tests, incl. a new case rejecting0,-1, and2.5)biome lintclean on changed files@