test(qualification): handle process exit during procfs status reads - #60
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Fixes #59. PR #58's Linux/Python 3.11 run reproduced an observation race in the pre-existing test helper:
/proc/<pid>/statdisappeared after the existence check, raisingProcessLookupErrorwhile checking an already-exited owned child.Change
FileNotFoundErrorandProcessLookupErrorduring that status read as process disappearance.This changes test observation only. It does not alter product subprocess cleanup or loosen its assertions.
Verification
Candidate
75821f2d6c5e717400c83377c11035e13f9a5899, based on PR #49.The supervisor verified unchanged source hashes during the run. The Linux race itself is evidenced by run https://github.com/DivyamTalwar/JITMIND/actions/runs/36506320213; the local macOS run uses deterministic procfs observations plus the unchanged real child-process tests. It is not relabelled as a native Linux reproduction.
Stacked on #49. This small follow-up will precede #58 so the instrumentation PR can retain a focused diff and rerun its complete matrix. No automatic merge.