Repository navigation
feat(checkpoints): validate closed event ranges and exact identities - #47
Open
DivyamTalwar wants to merge 7 commits into
Open
DivyamTalwar wants to merge 7 commits into
DivyamTalwar wants to merge 7 commits into
Conversation
…tmind-j07-reviewed-20260928 # Conflicts: # docs/open-work-preflight.md # tests/test_open_work_bindings.py
…tmind-j07-reviewed-20260928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and review order
J-07, refs #37. Stacked on #46 to keep the reviewed series composable; the checkpoint extension remains optional. Native JITMIND implementation of closed-range/tool-boundary invariants informed by
omnara-ai/omnara@5fa80ea4f3be999aa63fbc44513de3020ee940af,internal/storage/executionstore/context_checkpoints_boundary.go. No Omnara service or other user product is required.Changes
Composition review
The initial independent review found five correctness/resource issues; those were corrected. A subsequent composition run found six interactions with J-01 tests/error handling; those were also fixed before publication. The existing atomic regression tests now exercise the actual v2 path/open boundary, retain a genuine-v1 fixture, and preserve their original failure/previous-bytes/uncertain-outcome assertions rather than dropping them.
Verification
Candidate
75574aef663b25f48619fcf2179e59492ddbe49b; parent8591dd75ea1289f66cd98ef42b39ae5227867157.Full supervisor verification with all preceding components and real parser dependencies:
The full suite includes spawned process/crash/restart, JSON collision/corruption, live lock ownership and inherited persistence regressions. Sources remained unchanged during verification. No live-provider calls.
Retention and operational limits
Raw events and immutable history follow the documented retention policy; this does not restore arbitrary processes, browsers, filesystems or external side effects. Gaps cannot be guessed or silently backfilled. Multi-file legacy cleanup is not represented as a crash-atomic database transaction. Local DELETE/FULL SQLite and POSIX helper assumptions remain explicit; hardware power loss and other platforms are not thereby qualified.
See
docs/checkpoints.mdfor exact APIs, schema, legacy migration, error compatibility and rollback. Merge prerequisites, retarget and rerun CI. No automatic merge or production certification.