feat: add accessible VaultProgressBar primitive#145
Closed
go165 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VaultProgressBarprimitive with clamped 0-100 values, NaN/non-finite handling, ARIA progressbar semantics, optional labels, and semantic token-driven fill colors.VaultCardto render progress from its existingprogressPctprop and reuses the primitive inVaultDetail;Dashboardconsumes it throughVaultCard.Closes #130
Verification
npm test -- --run src/components/__tests__/VaultProgressBar.test.tsx src/components/__tests__/VaultCard.test.tsx-> 2 files / 9 tests passed;VaultProgressBar.tsxandVaultCard.tsxreported 100% coverage.npx tsc --noEmit --pretty false --skipLibCheck --jsx react-jsx --module ESNext --target ES2020 --moduleResolution Bundler --allowSyntheticDefaultImports --esModuleInterop src/components/VaultProgressBar.tsx src/components/VaultCard.tsx src/pages/VaultDetail.tsx-> passed.git diff --check-> passed.Note: repo-wide
npx tsc -b --pretty falsestill fails on the upstreamsrc/components/Field.tsxforwardRef syntax issue (TS1005at lines 68-69), which is unrelated to this change.Payout
0x1f0130669ca6fd02e025a984cc038f139df19a2f