Skip to content

feat: add accessible VaultProgressBar primitive#145

Closed
go165 wants to merge 1 commit into
Disciplr-Org:mainfrom
go165:go165/vault-progress-bar
Closed

feat: add accessible VaultProgressBar primitive#145
go165 wants to merge 1 commit into
Disciplr-Org:mainfrom
go165:go165/vault-progress-bar

Conversation

@go165

@go165 go165 commented Jun 17, 2026

Copy link
Copy Markdown

Summary

  • Adds a reusable VaultProgressBar primitive with clamped 0-100 values, NaN/non-finite handling, ARIA progressbar semantics, optional labels, and semantic token-driven fill colors.
  • Wires VaultCard to render progress from its existing progressPct prop and reuses the primitive in VaultDetail; Dashboard consumes it through VaultCard.
  • Adds focused component/card tests plus design-system documentation.

Closes #130

Verification

  • npm test -- --run src/components/__tests__/VaultProgressBar.test.tsx src/components/__tests__/VaultCard.test.tsx -> 2 files / 9 tests passed; VaultProgressBar.tsx and VaultCard.tsx reported 100% coverage.
  • npx tsc --noEmit --pretty false --skipLibCheck --jsx react-jsx --module ESNext --target ES2020 --moduleResolution Bundler --allowSyntheticDefaultImports --esModuleInterop src/components/VaultProgressBar.tsx src/components/VaultCard.tsx src/pages/VaultDetail.tsx -> passed.
  • git diff --check -> passed.

Note: repo-wide npx tsc -b --pretty false still fails on the upstream src/components/Field.tsx forwardRef syntax issue (TS1005 at lines 68-69), which is unrelated to this change.

Payout

0x1f0130669ca6fd02e025a984cc038f139df19a2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build a VaultProgressBar component driven by VaultCard's progressPct

2 participants