feat: validate CreateVault form inputs#142
Closed
go165 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123.
Summary
CreateVaultso invalid values render inlineFielderrors and block submission before backend/contract calls.FieldforwardRef syntax so the validation path can compile and be tested.Validation
npm test -- --run src/utils/__tests__/vaultValidation.test.ts src/pages/__tests__/CreateVault.test.tsxFocused result: 2 files passed, 7 tests passed;
CreateVault.tsxandvaultValidation.tsboth reported 100% coverage in the focused run.Baseline notes
npm run buildis currently blocked by pre-existing repo-wide TypeScript issues outside this PR, including missing Vitest globals in existing tests, an existing@testing-library/user-eventimport without a dependency inVaults.test.tsx, and unrelated unused/missing imports.npm run lintis likewise blocked by existing repo-wide lint errors outside these changed TypeScript files. A scoped lint on the changed TS files passed; the markdown doc is ignored by the current ESLint config.Reward/payment note if this issue is selected for GrantFox reward: Base/EVM address
0x1f0130669ca6fd02e025a984cc038f139df19a2f.