Conversation
This is intended as a starting point for porting more tests. It shows what one can already do with dixous-test. Since this depends on some changes to Dioxus and Blitz which have not yet been released (as of the time of writing), this adds dependency overrides to point to the current HEAD of the respective Git repositories.
hovinen
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests using dioxus-test to the
Sheetcomponent mirroring the existing Playwright tests inplaywright/sheet.spec.ts.Unfortunately, it turns out that some of the functionality in the
Sheetcomponent uses JavaScript, so is unavailable on the native stack. This PR includes corresponding tests, but ignores them with reference to the missing functionality. Other tests had to be adjusted to account for this.This updates the dependency on Dioxus and related crates to point to the Git repositories, in various branches containing required functionality. These branches are themselves based on HEAD, which contains some breaking changes compared to existing functionality. This is the first PR in the chain which exercises the
previewcrate, where some changes were needed to make the code compile. The changes will presumably also need to be applied to the earlier PRs in this chain before merging.This builds on top of #301 .