Add support for Fianium - #18
Conversation
|
@jacobfeder Thanks for this contribution! It looks good and I like the with/as addressing method. Sorry for this delayed response. I graduated, and I guess my notifications aren't set up right for this project. I haven't fully looked over this yet, but my understanding is the the Extreme and Fianium should basically be the same. I remember the NKT notation for these devices being a bit confusing. Actually, I believe my laser in grad school was technically a Fianium model. Wouldn't this additional class be redundant? Perhaps it would be better to modify the original Extreme class. What I see on a first pass is that you have: I'm not sure I think c) is more intuitive than the original, but a, b, and d seem like nice improvements. Did the Extreme class work with your setup? The register addresses seem to be identical, so I would have imagined that everything behaves normally. Please let me know what you think about that. I'll look into this over the next week or two, but I'm thinking it may just be better to merge your context management into the existing Extreme class. |
|
Hey @Briley645, |
Add support for SuperK FIANIUM (S4x3) devices.
I've made the interface slightly different by adding a context manager, e.g.
I think this is slightly nicer as it automatically handles disconnection. Let me know what you think!
Best,
Jacob