Skip to content

[DO NOT MERGE] make use of the bulk function call #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roynalnaruto wants to merge 1 commit into
base: feature/sprint-6
Choose a base branch
from
Open

[DO NOT MERGE] make use of the bulk function call #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dbWrapper/kyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ const getPendingKycApprovals = async (filter, limit = 10) => {
return pendingApprovals;
};

const setKycProcessed = async (id, txnId) => {
const setManyKycProcessed = async (ids, txnId) => {
await mongoUtil.getDB()
.collection(collections.KYC_APPROVALS)
.updateOne({ _id: id }, {
.update({ _id: { $in: ids } }, {
$set: {
status: 'processed',
txhash: txnId,
Expand Down Expand Up @@ -56,6 +56,6 @@ const setKycSuccess = async (txhash) => {
module.exports = {
addPendingKycApproval,
getPendingKycApprovals,
setKycProcessed,
setManyKycProcessed,
setKycSuccess,
};
37 changes: 21 additions & 16 deletions scripts/kyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const EthereumTx = require('ethereumjs-tx');

const {
getPendingKycApprovals,
setKycProcessed,
setManyKycProcessed,
setKycSuccess,
} = require('../dbWrapper/kyc');

Expand Down Expand Up @@ -30,26 +30,33 @@ const {

const keystore = require('../keystore/kyc-admin.json');

const _getCallData = (entry) => {
const _getField = (entries, fieldName) => {
const fields = [];
entries.forEach((entry) => {
fields.push(entry[fieldName]);
});
return fields;
};

const _getCallData = (entries) => {
return getContracts()
.daoIdentity
.updateKyc
.bulkUpdateKyc
.request(
entry.address,
'', // empty doc hash
entry.id_expiration,
_getField(entries, 'address'), '',
_getField(entries, 'id_expiration'),
)
.params[0]
.data;
};

const _txnObject = (entry, kycAdmin, nonce) => {
const _txnObject = (entries, kycAdmin, nonce) => {
return {
from: kycAdmin,
to: getContracts().daoIdentity.address,
gas: 300000,
gasPrice: 40 * (10 ** 9),
data: _getCallData(entry),
data: _getCallData(entries),
nonce,
};
};
Expand All @@ -71,14 +78,12 @@ const approveKyc = async (entry) => {
const processPendingKycs = async () => {
const pendingKycApprovals = await getPendingKycApprovals({ status: 'pending' }, 10);
if (pendingKycApprovals.length <= 0) return;
for (const entry of pendingKycApprovals) {
try {
const txnId = await approveKyc(entry);
await setKycProcessed(entry._id, txnId);
await insertPendingTransactions([{ txhash: txnId }]);
} catch (e) {
console.log('[ERROR] ', e);
}
try {
const txnId = await approveKyc(pendingKycApprovals);
await setManyKycProcessed(_getField(pendingKycApprovals, '_id'), txnId);
await insertPendingTransactions([{ txhash: txnId }]);
} catch (e) {
console.log('[ERROR] ', e);
}
};

Expand Down