Conversation
Refactor/e2xgrader multistage
Update/e2x jupyter backup
Add build-essential to bi-notebook to fix source installation of pack…
Fix GitHub Actions conditional expression warning
…rds-actions Added EventListener to catch unintentional navigation to different pages via custom-preload script in student exam mode.
…k-and-forwards-actions Revert "added EventListener to catch unintentional navigation to different pages"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and modernizes the
e2xgrader-notebookDocker image build system, introducing a multi-stage build with explicit targets forbase,student,student_exam, andteachermodes. It reorganizes requirements and configuration files, improves documentation, and enhances the backup configuration for student exam mode. The changes make the build process more modular, maintainable, and extensible, and provide clearer instructions for users.Dockerfile and Build System Refactor:
images/e2xgrader-notebook/Dockerfileto use multi-stage builds with separate targets forbase,student,student_exam, andteacher, improving modularity and maintainability. Mode-specific requirements and configurations are now organized in dedicated directories, and mode activation is handled in each stage. [1] [2].github/workflows/build_e2xgrader_images.ymlto use the new Docker build targets and simplified the conditional logic for listing images.Requirements and Dependency Management:
requirements/, updated thestudent_exam.txtto use a newer version ofe2x-jupyter-backup, and removed obsolete files.Configuration and Backup Improvements:
E2X_BACKUP_MAX_SIZE_MB,E2X_MIN_SECONDS_BETWEEN_BACKUPS), improved type safety, and moved configuration files to mode-specific directories.Documentation Updates:
images/e2xgrader-notebook/README.mdto document the new multi-stage build system, available build targets, updated usage instructions, and new backup configuration options. [1] [2] [3]Other Improvements:
build-essentialto thebi-notebookimage dependencies for broader compatibility.