Read secret from env var - #120
Merged
Merged
Conversation
weronika-malinowska-deltatre
requested review from
a team,
gedl and
mpontes
September 11, 2025 15:23
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
skurtEnd
approved these changes
Sep 11, 2025
mpontes
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Read secrets from env var. This change is backwards compatible, tokens can be provided as command args as well, same way it has been done so far.
WHY
To have more secure way of passing tokens.
AC
When env var is present it is used as token
TESTING:
TASK RUNS SUCCESSFULLY:
FILES PLACED SUCCESSFULLY:
TASK DEFINITION CONFIGURATION - CURRENTLY THE SECRET IS EXPOSED AS PLAINTEXT HERE:
