Delete Blacklisted Files and Folders When Finalising RSyncer #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tieneupin
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 43.60% 43.98% +0.38%
==========================================
Files 94 93 -1
Lines 10255 10189 -66
Branches 1333 1320 -13
==========================================
+ Hits 4472 4482 +10
+ Misses 5560 5486 -74
+ Partials 223 221 -2 🚀 New features to boost your workflow:
|
tieneupin
changed the title
tieneupin
added
enhancement
* Added 'substrings_blacklist' as an optional attribute upon initialsation of the RSyncer * When finalising, recursively delete directories and files that have patterns matching that of the substrings blacklist, while transferring the rest
… class upon its initialisation by the MultigridController
…nce it's used as an instance attribute
…eue', and 'flush_skipped' RSyncer class methods
tieneupin
force-pushed
the
delete-blacklisted-files
branch
from
b86c2e9 to
bf81ee4
Compare
…d without setting a substrings blacklist are as expected
stephen-riggs
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after PR #719.
With the implementation of a
substrings_blacklistkey to the MachineConfig Pydantic model as part of PR #707, we need to ensure that any files that are blacklisted do not then get transferred over to the destination by the RSyncer when a session is being finalised.This PR resolves that issue by passing the MachineConfig through the MultigridController to any instantiated RSyncers. When finalising the session, the RSyncers will delete the files and folders matching the blacklist criteria, while backing up and transferring other files.