Skip to content

Copy data-* into the HTML along with aria-* #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstelzer merged 2 commits into from
Aug 17, 2026
Merged

Copy data-* into the HTML along with aria-* #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8cb3a5
copy data-* into the HTML along with aria-*
dstelzer Jun 27, 2026
d391529
Merge branch 'main' into data-attributes
dstelzer Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/js/webfrontend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,14 +207,14 @@ function prepare_styles(styles, style_data) {
for(i = 0; i < styles.length; i++) {
mono = false;
let name = "aa-" + (styles[i]["style-name"] || i);
name = name.replace(/[^a-z0-9-]/g, '-'); // There shouldn't be spaces and such, but sanitize just in case
name = name.replace(/[^a-zA-Z0-9-]/g, '-'); // There shouldn't be spaces and such, but sanitize just in case
if(name in style_data) name = "aax-" + i; // Emergency fallback, guaranteed not to conflict
style_data[i] = { name:name, attrs:{} };

html += "." + name + " { ";
for(j in styles[i]) {
if(j.startsWith("aria-")) { // Copy aria-* declarations to a special array, since we want to assign these to the HTML tag, not just leave them in the CSS
if(j == "aria-role") { // The HTML name is simply "role"
if(j.startsWith("aria-") || j.startsWith("data-") { // Copy aria-* and data-* declarations to a special array, since we want to assign these to the HTML tag, not just leave them in the CSS
if(j == "aria-role") { // The HTML name is simply "role", not "aria-role", though it is an ARIA attribute
style_data[i].attrs["role"] = styles[i][j];
} else {
style_data[i].attrs[j] = styles[i][j];
Expand Down
Loading