Repository navigation
Stop two bridge tests depending on the runner's speed - #17
Merged
Merged
Conversation
The test let the channel take 300 ms to open, gave the call 100 ms and required the answer within 280 ms of wall-clock time. A slow Windows runner took 853 ms and failed it. The channel now takes 3 s and the bound is 2 s: still far below what a call that waited for the channel would take, and far above a slow runner's overhead.
When the watcher's signal cut the wrapper's wait short, some shells had already collected the command, so the wrapper found no process to wait for again and reported the signal's own number (138) instead of the stop's (143). Ask the shell once more for the status it kept, and when it kept none and a stop had begun, report the stop's TERM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found while releasing 1.7.0. Neither changes what the app
does for a user in any way they would notice.
wall-clock time; a slow Windows runner took 853 ms and failed the
v1.7.0 build. The test now uses a 3 s channel delay and a 2 s bound.
signal's number (138) instead of the stop's (143), because some shells
had already collected the command when the wrapper's wait was cut
short. The wrapper now asks the shell once more for the status it
kept, and counts a begun stop as the stop's TERM when it kept none.
150 of 150 runs under dash and under bash now give 143.
Tests: analyze clean, full suite and the real-sshd tests pass, local CI
passes.