Repository navigation
Add constraint-aware benchmarks and native Panda dual-arm support - #897
Merged
Merged
Conversation
Unify planner constraints, batched and paired execution, replay evidence and frozen input qualification. Add native single- and dual-Panda hardware providers.
Replace scalar collision proxies with explicit open-hand URDF meshes, migrate existing callers and convert contact poses to the runtime TCP once. Reject invalid HandOver grasp samples before endpoint IK.
yangchen73
force-pushed
the
yc/nmg-benchmark-native-hand
branch
from
October 28, 2026 13:23
9e8d6f7 to
364eb1f
Compare
yangchen73
marked this pull request as ready for review
October 28, 2026 14:29
[High impact] The PR appears safe to merge; no new blocking issue was established. SummaryAdds constraint-aware planner comparisons, native Panda hand support and grouped dual-arm planning.
No new actionable issues were established. This review used code inspection; no runtime tests were run.
|
…dencies Compare the TOPPRA failed trajectory with a start state promoted to the result dtype. Skip the RigidFormer recovery regression when its optional model dependencies are unavailable, consistent with neighboring tests. Validation: 40 CPU tests passed; original TOPPRA CUDA regression passed; RigidFormer regression skipped without roma. Black 26.10.1, API docs coverage (3293/3293), and git diff --check passed. Agent context remains accurate because this change only corrects test expectations and optional dependency guards.
Resolve the RigidFormer demo visualization conflict through its CLI configuration, preserving the disabled default and optional Viser support without duplicate keyword arguments. Validation: 42 focused visualization/kinematics tests passed, 5 skipped; demo --help and compilation passed; Black 26.10.1, API docs coverage (3293/3293), and git diff --cached --check passed. Existing context remains accurate; no further context changes are required for the conflict resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motion-generation comparisons need consistent constraint goals, per-row ownership and replay evidence across cuRobo, IK+TOPPRA, raw NMG and retimed NMG. This change adds that support and native Panda Hand integration for Franka single- and dual-arm manipulation.
Companion: NMG PR #35. Planning, solved timing, execution and physical success retain separate reports; official performance replay is Free-space only.
Validation
Follow-up OPW review fix: 114 CPU tests passed and the real CUDA retiming/FK regression passed. The original Warp dtype mismatch is reproduced before the fix. The regression verifies float64 trajectories are unchanged after scalar/batched FK.
Native input-freeze CPU regressions: 843 passed, 4 GPU/simulation tests deselected. The new known-support regression fails before the fix and passes after it; real holes, penetration, handle-only support and a 10 nm overhang remain rejected.
Black 26.10.1,
git diff --checkand public API coverage 3280/3280 passed. Existing motion-planning context remains accurate.The measured native integration batch on parent
29ff7e260passed six simulator/export tests and all 28 four-method design trials / 224 row outcomes. Its NMG fixture has zero training interactions.All eight Franka development/test input corpora and both full dual-arm evidence audits passed. Numerical requalification covers 794 Placement rows with exact native mesh hashes and unchanged task poses, grasps, endpoints, IDs and seeds. Original inputs and failures are independently preserved. Reserved test was prepared without candidate execution.
Fresh remote CI is observed separately from these local and measured checks. This PR does not report trained-policy quality or measured planner latency. Full input hashes and receipts are recorded in the companion freeze study.
Type of change
Benchmark/runtime enhancement and bug fix, with the explicit grasp-geometry API migration described above.