Repository navigation
Conversation
2044b2a to
6ecec1c
Compare
6ecec1c to
59bb5e7
Compare
[Medium impact] The changes add operator-run workflows around RigidFormer without changing general simulator behavior. The PR appears safe to merge, with non-blocking improvements to raw-data checks and report reliability.
|
| selected = sorted((raw / "data" / dataset).glob("*.parquet")) | ||
| if not selected: | ||
| raise FileNotFoundError("No official numeric scenes found") | ||
| selected_names = {str(p.relative_to(raw)) for p in selected} | ||
| for rel, info in needed.items(): | ||
| if not limit_per_split or rel.startswith("assets/") or rel in selected_names: | ||
| if not (raw / rel).is_file() or sha256(raw / rel) != info["sha256"]: | ||
| raise ValueError(f"Official raw data checksum differs: {rel}") |
There was a problem hiding this comment.
Unlisted shards bypass checksum checks
prepare discovers every local Parquet shard but checks hashes only for paths listed in the official manifest. An extra shard in a reused cache can therefore supply scenes without an official checksum check. Its converted contents then receive the pinned data_revision.
Before creating the output directory, reject selected shards missing from the manifest or select shards from the manifest itself.
Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/learning/rigidformer/_prepare.py
Line: 126-133
Comment:
**Unlisted shards bypass checksum checks**
`prepare` discovers every local Parquet shard but checks hashes only for paths listed in the official manifest. An extra shard in a reused cache can therefore supply scenes without an official checksum check. Its converted contents then receive the pinned `data_revision`.
Before creating the output directory, reject selected shards missing from the manifest or select shards from the manifest itself.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| if torch.distributed.is_nccl_available(): | ||
| loaded = ctypes.c_int() | ||
| ctypes.CDLL("libnccl.so.2").ncclGetVersion(ctypes.byref(loaded)) | ||
| nccl = [loaded.value // 10000, loaded.value % 10000 // 100, loaded.value % 100] |
There was a problem hiding this comment.
Optional metadata can block reports
If Torch supports NCCL but libnccl.so.2 cannot be loaded by name, evidence raises OSError. The Torch build check does not guarantee that this separate lookup succeeds. Even a completed single-GPU evaluation then loses its summary.
Catch the lookup failure and record an unavailable runtime version instead of failing the experiment.
Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/learning/rigidformer/_support/_evidence.py
Line: 66-69
Comment:
**Optional metadata can block reports**
If Torch supports NCCL but `libnccl.so.2` cannot be loaded by name, `evidence` raises `OSError`. The Torch build check does not guarantee that this separate lookup succeeds. Even a completed single-GPU evaluation then loses its summary.
Catch the lookup failure and record an unavailable runtime version instead of failing the experiment.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Description
Add an engine-rendered RigidFormer sphere demo to the
learning/rigidformershowcase, alongside pinned official-asset preparation, fixed-weight evaluation, raw/EMA export, independent author comparison and recovery checks.embodichain run-example learning/rigidformer demodisplays dynamic Newton XPBD spheres on the left and render-only model spheres on the right. The model receives four engine observations and performs one free rollout. The demo supports a native window or headless engine-camera recording, configurable resource paths and object selection, and writes MP4, a preview frame, aligned trajectories and source-identified metrics. Frames stream to the encoder. The README includes resource preparation and runnable commands.Stack
codex/rigidformer-official-trainingType of change
Validation
black .), API coverage 3287/3287, context validation and 42 context tests pass. Neural-dynamics context and the example index were updated; simulator lifecycle and launcher guidance remain accurate.Checklist
black .with Black 26.10.1.