Repository navigation
Add official RigidFormer architecture and weight import - #888
Merged
Merged
Conversation
6 tasks done
yuecideng
marked this pull request as ready for review
October 28, 2026 01:18
[Medium impact] The reviewed changes appear safe to merge, with no outstanding findings. SummaryAdds the pinned author's RigidFormer architecture, three MOVi presets, strict weight imports, and a public geometry API.
No new actionable issues were found in the changes since the previous review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the author's RigidFormer geometry architecture at
160fe0852c51cffae7b7440452b58d0b49db6df6asembodichain_models.dynamics.rigidformer, with its MIT attribution and three MOVi configurations. Strict official tensor/config imports preserve named architecture, shapes and dtypes; the model uses explicit Torch SDPA or a compatible Flash-Attention backend.This layer owns model construction, geometry validation and inference. CUDA geometry requires at least two valid objects; CPU construction and weight inspection remain available. Model integration uses dt=1, independently of physical seconds.
Stack
mainType of change
Validation
The
rigidformerextra declares onlyeinopsandroma; Torch selection remains governed by the project environment. Release-metadata checks (8 passed) and the built wheel confirm there is no model-specific Torch requirement.53 focused model, context and release-metadata checks pass, including native CUDA checkpoint/rollout and finite-padding coverage above 128 points.
Its wheel installs outside the checkout with no repository PYTHONPATH. Installed source bytes, configs/licenses and all three presets are checked; official-weight predictions match the frozen source baseline exactly.
API coverage: 3271/3271. Context routing/checks and Black 26.10.1 pass.
Focused model coverage protects independent loading/padding/import contracts. Shared training and reference qualification are supplied by the dependent layers.
Review follow-up
src/train.pydoes not forwarddecoder.num_register_tokensto the decoder. The adapter deliberately keeps the author's 16-token default even when a source config names another value, preserving the layout of official checkpoints.Checklist
black .with Black 26.10.1.