Skip to content

Align robot catalog tests with vendor modules and terminal width - #878

Merged
yuecideng merged 1 commit into
mainfrom
codex/sl-ci-catalog-compat
Oct 26, 2026
Merged

yuecideng merged 1 commit into
mainfrom
codex/sl-ci-catalog-compat

Conversation

@yuecideng

Copy link
Copy Markdown
Contributor

Description

Repair two tests after the vendor robot catalog migration in #875. The list-robot label case checks an unwrapped label at an explicit 120-column terminal width; narrow responsive table wrapping is not a label-semantic failure. The UR embodiment mock now targets the canonical embodichain_robots.universal_robots.ur_robot owner rather than a retired flat module.

Only two test files change (+3/-1). Production CLI/robot behavior, assertions, pytest import policy, CI selection and test gates are unchanged; no compatibility module or skip is added.

The same failures were exposed by the full main-based suites for #864, #859 and #858. This focused maintenance commit is carried into those branches so they can be checked by the unchanged main CI while this fix is reviewed.

Validation

  • On exact main c5b1fdfc2, the original two cases fail with the CI errors; after the change both pass.
  • Both complete related modules pass: 42 tests, including capture from an external 80-column environment with only the label case requesting 120 columns.
  • Simulation managers remain mocked; no world is created. A visible idle GPU was used only to import this environment's CUDA-only Open3D build.
  • Black 26.10.1 black ., whitespace checks and API coverage 3206/3206 pass.

Type of change

  • Test compatibility maintenance after the vendor migration.

Checklist

  • Run black ..
  • Keep original semantic assertions and CI gates.
  • Verify an actual red-to-green regression with proportional existing coverage.
  • Review context: existing production ownership remains accurate; no context edit is needed.
  • Leave merging to the requesting user's review.

@yuecideng yuecideng added bug Incorrect existing behavior or a fix restoring the intended behavior. ci Continuous integration, build automation and release automation. robot Robot runtime, presets, control groups, calibration and robot support. labels Oct 25, 2026
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This test-only PR appears safe to merge.

Summary

This PR repairs two tests after the robot catalog moved to vendor modules.

  • The UR5 catalog test imports its robot module from the vendor package.
  • The robot-list test fixes its table width for the label check.

Production code and existing assertions are unchanged. No actionable issues were found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "test: align robot catalog checks with ve..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Incorrect existing behavior or a fix restoring the intended behavior. ci Continuous integration, build automation and release automation. robot Robot runtime, presets, control groups, calibration and robot support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant