Repository navigation
Align W1 V030 rendering materials with V021 - #853
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryAligns W1 V030’s rendering materials with V021.
Reviews (2) · Last reviewed commit: "chore(assets): remove one-off W1 materia..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
W1 V030 rendered with a darker yellow and different plastic roughness than V021. Align its yellow/dark palette and roughness with V021, update the
DexforceW1V030download checksum, and refresh the documentation render and asset provenance.The existing HF path
dexforce_w1/v030/w1.ziphas been overwritten in place. Dependency: published asset revision cbaab0e. No package dependency changes.Type of change
Screenshots
Same camera, display pose, lighting and OfflineRT settings:
Validation
pytest tests/data/test_download_prefix.py tests/data/test_dataset.py -q: 8 passed.get_data_path()download from the default mirror into an empty cache; MD5/SHA256 and all referenced meshes verified. Existing V030 cache repair also passed.black ., API documentation coverage (3045/3045), andgit diff --checkpassed.Existing data tests plus real download, archive and rendering checks cover this asset update; no new pytest cases were needed. Agent context review: no update needed because asset ownership, path resolution, cache lifecycle and robot configuration contracts remain accurate.
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicable.