Repository navigation
Fix UR3 materials and refresh robot documentation renders - #845
Conversation
[Medium impact] The changes reach the UR asset-loading workflow and three robot documentation pages. The PR appears safe to merge, with a non-blocking error in the CLI's download status.
|
| prefix = type(self).__name__ | ||
| # Assembly signatures include URDF paths, not referenced mesh contents. | ||
| # A versioned source directory also invalidates old assembled materials. | ||
| prefix = f"{type(self).__name__}V4" |
There was a problem hiding this comment.
Download status checks old files
The new UniversalRobotsV4 cache name leaves embodichain data list checking the old directory. cmd_list() builds its path from the class name, so a fresh V4 download still appears missing, while an old V3 cache can appear ready without V4 being present.
Keep the versioned directory, but update the CLI to check the asset's declared cache prefix without downloading it.
Knowledge Base Used: Asset and dataset management
Prompt To Fix With AI
This is a comment left during a code review.
Path: embodichain/data/assets/robot_assets.py
Line: 322
Comment:
**Download status checks old files**
The new `UniversalRobotsV4` cache name leaves `embodichain data list` checking the old directory. `cmd_list()` builds its path from the class name, so a fresh V4 download still appears missing, while an old V3 cache can appear ready without V4 being present.
Keep the versioned directory, but update the CLI to check the asset's declared cache prefix without downloading it.
**Knowledge Base Used:** [Asset and dataset management](https://app.greptile.com/dexforce/-/custom-context/knowledge-base/dexforce/embodichain/-/docs/asset-data-management.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Description
UR3/UR3e assets darkened the silver links and blue joint covers. Select the corrected
UniversalRobots_v4.zipand checksum, retain the configured download source with a Hub fallback, and use a versionedUniversalRobotsV4cache directory so existing assembled robots refresh their copied mesh materials. PublicUniversalRobots/...asset references stay stable.Refresh all six UR documentation images plus the CobotMagic and Aloha Mini 2 Pro illustrations using native OfflineRT. Add camera, lighting and display-pose manifests, improve figure layouts, and label the model, gripper and control-group details. CobotMagic and Aloha Mini use soft studio area lights; UR captures retain default lighting.
Dependencies: none. No associated issue.
Type of change
Validation
black .with Black 26.3.1: 1,504 files unchanged.python docs/scripts/check_api_docs.py: 2,805/2,805 exports documented.python -m pytest -q tests/data/test_download_prefix.py: 6 passed.python -m pytest -q -c /dev/null --noconftest tests/test_agent_context_map.py tests/test_agent_context_tools.py: 42 passed.get_data_path()resolved all six public UR asset paths intoUniversalRobotsV4; the published 54.64 MiB archive matched MD5a92eda28a1d2f9034252cdb2936ceffc.context.py check, affected-topic review and context size review: passed. Revised the data-assets overview to explain the V4 cache boundary and stable public paths.git diff --check: passed.Test necessity reviewed: extended existing download-prefix cases to cover the versioned UR cache, configured-source priority and deduplicated Hub fallback. Archive comparison and the real download verify the asset update; documentation builds and image checks cover the render refresh. No additional simulation tests are needed because geometry, kinematics, collisions and inertial definitions are unchanged.
Screenshots
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicable (no API changes; gate passed).