Skip to content

fix(entries): filter root-level entries client-side when path is empty #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raphaël Larivière (Sylfwood) merged 1 commit into from
Feb 25, 2026
Merged

fix(entries): filter root-level entries client-side when path is empty #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.18.0
0.18.1
14 changes: 13 additions & 1 deletion entries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func (c *Client) getEntries(ctx context.Context, vaultId string, opts GetEntries
if opts.Name != nil {
q.Set("name", *opts.Name)
}
if opts.Path != nil {
if opts.Path != nil && *opts.Path != "" {
q.Set("path", *opts.Path)
}
q.Set("page", fmt.Sprintf("%d", currentPage))
Expand Down Expand Up @@ -241,5 +241,17 @@ func (c *Client) getEntries(ctx context.Context, vaultId string, opts GetEntries
currentPage++
}

// When path is explicitly set to "", the server ignores the filter and returns all entries.
// We apply client-side filtering to return only root-level entries (entries with no path).
if opts.Path != nil && *opts.Path == "" {
var rootEntries []Entry
for _, entry := range allEntries {
if entry.Path == "" {
rootEntries = append(rootEntries, entry)
}
}
return rootEntries, nil
}

return allEntries, nil
}