feat(net-scan): align gateway scans with local planning#1776
feat(net-scan): align gateway scans with local planning#1776irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit intomasterfrom
Conversation
Let maintainers know that an action is required on their side
|
f5e9736 to
eb59efa
Compare
Adds selected network scan sources, explicit target/range planning, interface-aware scan execution, the v1 result format, and gateway API/OpenAPI support while preserving the legacy event format. ARP/NDP discovery and MAC enrichment are intentionally excluded from this review slice and remain available on backup-feat-network-scan-improvement-with-arp-ndp.
eb59efa to
d0ef8ab
Compare
Summary
Brings gateway-backed network scans closer to local scan parity without the ARP/NDP discovery slice.
target+range,interface_idsource selection, IPv4/IPv6 family validation, oversized-range guard, structuredrange_outside_selected_interfaces400, independentreport_ping_{start,success,failure}knobs,enable_failurekept as a legacy TCP-only alias,max_ping_concurrency/max_tcp_probe_concurrency, andinterface_bind_strict./jet/net/interfaceswith stable source IDs plus interface metadata and capability flags. Documents/jet/net/scanin OpenAPI. Adds RFC 8594Deprecation/Sunset/Linkheaders to the legacy/jet/net/configendpoint.response_format=network_scan_result_v1while preserving the legacy websocket event format.ScanEventFilterConfig, adds named source/link metadata structures, and moves scanner/proto unit tests undersrc/tests/modules.ARP/NDP neighbor discovery, active probing, passive neighbor snapshots, and MAC enrichment were removed from this PR and preserved locally on
backup-feat-network-scan-improvement-with-arp-ndpfor a follow-up review slice.Current diff: 34 files changed, +4612/-602.
Test plan
Passed:
cargo +nightly fmt --all -- --checkcargo check --workspace --testscargo clippy --workspace --tests -- -D warningscargo test -p network-scanner-proto -p network-scanner-net -p network-scanner --libcargo test -p devolutions-gateway --lib apiFull workspace tests:
cargo test --workspacecurrently fails in the existingtestsuiteintegration binary with 19 CLI/integration failures, including gateway heartbeat/AI gateway/Jetsocat/TLS anchoring/traffic audit cases. The failure includes a poisonedLazyLockintestsuite::cli::dgw_tokio_cmd, so this needs separate investigation before claiming full-suite green.Still to validate separately: