Skip to content

Retry pip user installs before breaking system packages#4569

Open
Nacai (B67687) wants to merge 1 commit intoDevolutions:mainfrom
B67687:fix/pip-user-before-break-system-packages
Open

Retry pip user installs before breaking system packages#4569
Nacai (B67687) wants to merge 1 commit intoDevolutions:mainfrom
B67687:fix/pip-user-before-break-system-packages

Conversation

@B67687
Copy link
Copy Markdown

@B67687 Nacai (B67687) commented Apr 10, 2026

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

This adjusts the pip retry flow for externally managed environments.

When pip reports externally-managed-environment, UniGetUI currently retries immediately with --break-system-packages. This change makes the first retry use --user instead, and only falls back to --break-system-packages if the user-scoped retry still cannot proceed.

That keeps the existing fallback in place, but prefers the less invasive pip path first.

Validation:

  • Restored and built src/UniGetUI.PackageEngine.Managers.Pip/UniGetUI.PackageEngine.Managers.Pip.csproj locally on Windows with .NET SDK 10.0.104.
  • Restored and built src/UniGetUI.sln locally on Windows with -p:Platform=x64.
  • Used MSBuildEnableWorkloadResolver=false during local validation due SDK workload-resolver issues on this machine.

Follow-up to #4542

@B67687 Nacai (B67687) marked this pull request as ready for review April 10, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant