feat(connector): expose SUPPORT_DYN_VC_GFX_PROTOCOL early-cap flag for EGFX clients#1237
Open
GlassOnTin wants to merge 1 commit intoDevolutions:masterfrom
Open
feat(connector): expose SUPPORT_DYN_VC_GFX_PROTOCOL early-cap flag for EGFX clients#1237GlassOnTin wants to merge 1 commit intoDevolutions:masterfrom
GlassOnTin wants to merge 1 commit intoDevolutions:masterfrom
Conversation
…r EGFX clients Currently, `early_capability_flags` in the GCC core data is built from a fixed set in `connection.rs`. Clients that want to use the Graphics Pipeline Extension (MS-RDPEGFX) — by attaching a DvcClientProcessor for `Microsoft::Windows::RDS::Graphics` — have no way to set `SUPPORT_DYN_VC_GFX_PROTOCOL` without forking the connector, and modern Windows servers won't open the EGFX channel unless the client advertises support. This commit adds an opt-in `Config.support_dyn_vc_gfx_protocol: bool` (default `false`). When set, the flag is OR'd into `early_capability_flags` alongside the existing `WANT_32_BPP_SESSION` conditional. Existing consumers are unaffected; the doc comment includes a safety note that setting this without an EGFX implementation will cause Windows to stop sending legacy bitmap updates, leaving the desktop blank. Used downstream by Haven (an Android RDP/VNC client) which implements EGFX with ClearCodec + RemoteFxProgressive decoders; this lets us drop the vendored ironrdp-connector fork. Default `false` to preserve current behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
early_capability_flagsin the GCC core data is built from a fixed set inconnection.rs. Clients that want to use the Graphics Pipeline Extension (MS-RDPEGFX) — by attaching aDvcClientProcessorforMicrosoft::Windows::RDS::Graphics— have no way to setSUPPORT_DYN_VC_GFX_PROTOCOLwithout forking the connector, and modern Windows servers won't open the EGFX channel unless the client advertises support.This PR adds an opt-in
Config.support_dyn_vc_gfx_protocol: bool(defaultfalse). When set, the flag is OR'd intoearly_capability_flagsalongside the existingWANT_32_BPP_SESSIONconditional. Existing consumers are unaffected; the doc comment includes a safety note that setting this without an EGFX implementation will cause Windows to stop sending legacy bitmap updates, leaving the desktop blank.Used downstream by Haven (an Android RDP/VNC client) which implements EGFX with ClearCodec + RemoteFxProgressive decoders; this lets us drop a vendored fork of
ironrdp-connectorwe currently carry just for this one flag.Default
falseto preserve current behaviour.cargo check --workspaceclean — six other in-treeConfig { … }builders updated with the default-false field.