Skip to content

fix(ui): prevent long toast messages from overflowing #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WCY-dt merged 1 commit into from
Aug 26, 2026
Merged

fix(ui): prevent long toast messages from overflowing #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions frontend/src/App.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { describe, it, expect, vi } from 'vitest';
import { readFileSync } from 'node:fs';
import { nextTick } from 'vue';
import { mount } from '@vue/test-utils';
import { createPinia } from 'pinia';
Expand All @@ -15,6 +16,14 @@ const createStub = (name: string) => ({
});

describe('App', () => {
it('keeps long toast messages inside narrow viewports', () => {
const toast = readFileSync('src/components/common/Toast.vue', 'utf8');
expect(toast).toContain('calc(100vw-2rem)');
expect(toast).toContain('overflow-wrap: anywhere');
expect(toast).toContain('min-w-0 flex-1');
expect(toast).toContain('shrink-0');
});

it('renders and reacts to interface typography settings', async () => {
setSettingsFromRawData({});
const pinia = createPinia();
Expand Down
21 changes: 13 additions & 8 deletions frontend/src/components/common/Toast.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,16 @@ function handleClose() {

<template>
<div v-if="show" :class="['toast', `toast-${type}`, show ? 'toast-show' : 'toast-hide']">
<div class="flex items-center gap-3">
<PhCheckCircle v-if="type === 'success'" :size="20" />
<PhXCircle v-else-if="type === 'error'" :size="20" />
<PhWarning v-else-if="type === 'warning'" :size="20" />
<PhInfo v-else :size="20" />
<span class="flex-1 toast-message selectable-text">{{ message }}</span>
<button class="text-xl opacity-70 hover:opacity-100 transition-opacity" @click="handleClose">
<div class="flex min-w-0 items-center gap-3">
<PhCheckCircle v-if="type === 'success'" :size="20" class="shrink-0" />
<PhXCircle v-else-if="type === 'error'" :size="20" class="shrink-0" />
<PhWarning v-else-if="type === 'warning'" :size="20" class="shrink-0" />
<PhInfo v-else :size="20" class="shrink-0" />
<span class="min-w-0 flex-1 toast-message selectable-text">{{ message }}</span>
<button
class="shrink-0 text-xl opacity-70 hover:opacity-100 transition-opacity"
@click="handleClose"
>
<PhX :size="20" />
</button>
</div>
Expand All @@ -54,7 +57,7 @@ function handleClose() {
<style scoped>
@reference "../../style.css";
.toast {
@apply z-[60] px-5 py-3 rounded-lg shadow-lg border min-w-[300px] max-w-md;
@apply z-[60] px-5 py-3 rounded-lg shadow-lg border w-[min(28rem,calc(100vw-2rem))] max-w-md;
}
.toast-show {
animation: slideIn 0.3s cubic-bezier(0.16, 1, 0.3, 1);
Expand Down Expand Up @@ -92,6 +95,8 @@ function handleClose() {
-moz-user-select: text;
-ms-user-select: text;
cursor: text;
overflow-wrap: anywhere;
word-break: break-word;
}
@keyframes slideIn {
from {
Expand Down