Repository navigation
fix: load keyHint from the pi-tui chrome subpath on Oh My Pi 18 - #13
Open
crxssrazr93 wants to merge 1 commit into
Open
crxssrazr93 wants to merge 1 commit into
crxssrazr93 wants to merge 1 commit into
Conversation
Oh My Pi 18 dropped @oh-my-pi/pi-coding-agent/modes/components/keybinding-hints from its host-package map; the module now lives at @oh-my-pi/pi-tui/chrome/keybinding-hints. Bun reports the missing subpath as "Cannot find package '@oh-my-pi/pi-coding-agent'", which aborted `omp plugin install` during extension validation (issue DevVig#5). Bump the @oh-my-pi/pi-tui dev dependency to ^18.13.3 so tsc resolves the new subpath; the rest of the dev pins still type-check against it.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omp plugin installaborts on Oh My Pi 18.x during extension validation:Root cause is one import. Oh My Pi 18 moved
keyHintfrom@oh-my-pi/pi-coding-agent/modes/components/keybinding-hintsto@oh-my-pi/pi-tui/chrome/keybinding-hints, and the old subpath is no longer in thehost-package map. Bun reports a missing subpath as a missing package, which is
why the message names the package root even though the root and every other
@oh-my-pi/*specifier resolves.Fixes #5.
Type of change
Checklist
bun run typecheckpassesbun run testpassestests/unit-context-window.mjs— N/A, no routing changeNotes
Verified on omp 18.13.3 / Linux:
@oh-my-pi/pi-coding-agent/modes/components/keybinding-hintsfails with the exact install error; importing
@oh-my-pi/pi-tui/chrome/keybinding-hintsloads and exportskeyHint.of testing), and completes live turns through the bridge.
@oh-my-pi/pi-tuidev dependency raised to^18.13.3because 16.x/17.x don't shipchrome/keybinding-hints, sotsc --noEmitcannot resolve the new subpath. The other@oh-my-pi/*dev pins stay at^16.3.6and still type-check against pi-tui 18.Caveat for the maintainer: this drops Oh My Pi 17 compatibility for the
keyHintlookup.If 17 support matters, the alternative is a dynamic import with a fallback to the old
subpath; I kept the static import because the plugin's other host imports already assume a
current host map.