Skip to content

Port upstream bridge updates through 2026-10-23 to OMP - #12

Open
dmytroleonenko wants to merge 2 commits into
DevVig:mainfrom
dmytroleonenko:codex/port-upstream-2026-10-23
Open

dmytroleonenko wants to merge 2 commits into
DevVig:mainfrom
dmytroleonenko:codex/port-upstream-2026-10-23

Conversation

@dmytroleonenko

@dmytroleonenko dmytroleonenko commented Oct 28, 2026 •

Copy link
Copy Markdown

Summary

The OMP port still used the July bridge snapshot. Synchronize its runtime with elidickinson/pi-claude-bridge through 2026-10-23, commit 6aa276a1498e5376363f5c1f8cf04bfcaee38c93 (0.9.3 plus subsequent fixes), while retaining OMP's on-demand 1M/200K picker entries.

This brings the updated tool-id/MCP transport, parallel results, images and carried attachments, steering, cancellation and stale-query cleanup, immutable finalized messages, per-session mirrors, prompt capture, rate-limit metadata and reasoning usage. Agent SDK is pinned to 0.3.308 and cc-session-io moves to 0.4.0.

Most added lines are upstream regression suites, recorded fixtures and historical diagnostics. The sync notes and original upstream changelog are included under documentation/.

OMP adaptations

  • Preserve OMP's rendered prompt blocks and developer reminders, including project rules, skills, append/custom/extension instructions and images; normalize native schemas with toolWireSchema before MCP exposure.
  • Use session_switch, hasProvider, native renderers and OMP thinking metadata. Child lifecycle events preserve the parent's parked session.
  • Leave compaction and branch-summary ownership with OMP/other extensions. Route their requests to isolated SDK summaries using OMP's exported summarization prompt. A registry-local adapter carries the owning session id through the bridge's unused key/resolver when OMP replaces the summary signal/request id; other providers' credentials are untouched.
  • Populate models from OMP's catalog and retain the window variants, explicit window ids and configured default. Window metadata and requested runtime ids stay consistent when only one window is supported.
  • Run independent unit suites in Bun and add an actual OMP CLI smoke with controlled SDK output.
  • Incorporate PR #3: start clean when rebuilt history contains no replayable messages, clearing only the owning OMP session's stale mirror. Regression tests cover an empty import and an emptied child-session rebuild while preserving the parent.

Target runtime: OMP >=18.13.2, Bun >=1.4.4. Development dependencies pin OMP 18.13.2.

Migration

  • AskClaude is now opt-in and deprecated upstream; Claude Code auto-memory defaults to off.
  • Retire provider.appendSystemPrompt / provider.settingSources: use OMP's effective prompt and context/skills controls.
  • Automatic Fable 5 routing follows upstream's 1M measurement; its 200K alternative remains available. forceTwoHundredK overrides all 1M choices.
  • Context-window mappings inherit the documented upstream measurements. No new served-window or plan-entitlement measurements are claimed.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / internal

Validation

  • bun install --frozen-lockfile
  • bun run typecheck
  • bun run test — 379 tests in 46 isolated suites
  • bun run test:smoke — actual OMP 18.13.2 CLI: extension load, provider selection, instruction forwarding, response delivery; controlled SDK
  • Context routing covered in tests/unit-context-window.mjs, including supported-window fallback
  • Real OMP compaction ownership and concurrent compaction/tree summaries in different directories tested with a controlled SDK
  • Shell syntax checked for all six imported shell scenarios

Manual live validation on 2026-10-28 used a first-party Claude Code subscription login and Haiku 4.5: a CLI request returned the expected marker; a two-turn RPC session executed OMP's native read through MCP and recalled the file token in the next turn without another tool call.

The full paid integration/diagnostic matrix and mobile clients were not rerun. Historical diagnostic reports are explicitly labeled as upstream Pi evidence.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-28T13:46:52.220996Z
We couldn’t complete this review. Comment @codex review to try again.
e8bc4fc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22562158-9a27-4c21-8af4-e80811132061
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

LaurensBosscher added a commit to LaurensBosscher/omp-claude-bridge that referenced this pull request Oct 28, 2026
Conflicts resolved to the PR side. The fork's own fixes (session-limit
fallback, developer-role turns, catalog models with 1M defaults, max effort,
per-session state, provider registration) are covered by the PR. Dropped
tests/unit-convert.mjs, which tested the replaced isPromptRole design.
Adapt the empty-rebuild guard from DevVig#3 (177a054) to per-OMP-session mirrors. Add regressions for an empty first import and an emptied child-session rebuild that must preserve its parent.

Co-authored-by: Daniel Sauer <daniel.a.d.sauer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant